Skip to content

🎨Director-v0: compatible with both registries + upgraded registry to v3 #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2025
Merged

🎨Director-v0: compatible with both registries + upgraded registry to v3 #8240

merged 4 commits into from
Aug 21, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 20, 2025 •
edited
Loading

What do these changes do?

The registry v3 deprecates the old schema v1 way of reading labels.
see the following link for info about Docker Image Manifest V2, schema V2 (former was V1 and is deprecated since 2024 apparently). The V2 format also brings multi-arch images (which this PR does not handle).

https://distribution.github.io/distribution/spec/manifest-v2-2/

A test was added to ensure compatibility

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Voyager milestone Aug 20, 2025
@sanderegg sanderegg self-assigned this Aug 20, 2025
@sanderegg sanderegg added the a:director issue related with the director service label Aug 20, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg mentioned this pull request Aug 20, 2025
Closed
@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.98%. Comparing base (d9aef02) to head (59ad06b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8240      +/-   ##
==========================================
- Coverage   88.02%   87.98%   -0.04%     
==========================================
  Files        1916     1916              
  Lines       74053    74066      +13     
  Branches     1301     1301              
==========================================
- Hits        65184    65170      -14     
- Misses       8478     8504      +26     
- Partials      391      392       +1
Flag Coverage Δ
integrationtests 63.96% <ø> (ø)
unittests 86.64% <86.36%> (-0.03%) ⬇️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.04% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.79% <ø> (-0.03%) ⬇️
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.90% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.59% <ø> (-0.79%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.51% <86.36%> (+0.36%) ⬆️
director_v2 90.86% <ø> (-0.06%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.05% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (ø)
storage 86.34% <ø> (-0.21%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.07% <ø> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9aef02...59ad06b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 59ad06b.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [unit] dynamic-sidecar (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
unit-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View

GitHK
GitHK approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Supporting both versions is ideal.

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 21, 2025
mrnicegyu11
mrnicegyu11 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice, thanks a lot for this! 🎈

@sanderegg sanderegg merged commit dc6f3c8 into ITISFoundation:master Aug 21, 2025
146 of 148 checks passed
@sanderegg sanderegg deleted the registry/upgrade-to-v3 branch August 21, 2025 07:18
@odeimaiz
Copy link
Member

👍

This was referenced Aug 21, 2025
Merged
Open
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:director issue related with the director service t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @odeimaiz @GitHK @mrnicegyu11